]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
tracing/eprobe: Fix to release eprobe when failed to add dyn_event
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 29 Nov 2024 16:47:47 +0000 (01:47 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Sun, 8 Dec 2024 14:25:09 +0000 (23:25 +0900)
Fix eprobe event to unregister event call and release eprobe when it fails
to add dynamic event correctly.

Link: https://lore.kernel.org/all/173289886698.73724.1959899350183686006.stgit@devnote2/
Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/trace/trace_eprobe.c

index ebda68ee9abff9013580b2fcee0b55a405b60b57..be8be0c1aaf0f17d80ba228c06e1ac560b38b90c 100644 (file)
@@ -963,6 +963,11 @@ static int __trace_eprobe_create(int argc, const char *argv[])
                goto error;
        }
        ret = dyn_event_add(&ep->devent, &ep->tp.event->call);
+       if (ret < 0) {
+               trace_probe_unregister_event_call(&ep->tp);
+               mutex_unlock(&event_mutex);
+               goto error;
+       }
        mutex_unlock(&event_mutex);
        return ret;
 parse_error: