]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
authorMiaohe Lin <linmiaohe@huawei.com>
Thu, 1 Jul 2021 01:50:36 +0000 (18:50 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:47 +0000 (16:53 +0200)
[ Upstream commit dac0d1cfda56472378d330b1b76b9973557a7b1d ]

There is a memory leak in z3fold_destroy_pool() as it forgets to
free_percpu pool->unbuddied.  Call free_percpu for pool->unbuddied to fix
this issue.

Link: https://lkml.kernel.org/r/20210619093151.1492174-6-linmiaohe@huawei.com
Fixes: d30561c56f41 ("z3fold: use per-cpu unbuddied lists")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
Cc: Hillf Danton <hdanton@sina.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
mm/z3fold.c

index 6d3d3f698ebb9f91db74662b25fe68b0bc86650b..e97143713021e02c5565ec4c40c9e3dae73b06bc 100644 (file)
@@ -839,6 +839,7 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool)
        destroy_workqueue(pool->compact_wq);
        destroy_workqueue(pool->release_wq);
        z3fold_unregister_migration(pool);
+       free_percpu(pool->unbuddied);
        kfree(pool);
 }