]> www.infradead.org Git - users/willy/xarray.git/commitdiff
io_uring/napi: remove duplicate io_napi_entry timeout assignation
authorOlivier Langlois <olivier@trillion01.com>
Mon, 12 Aug 2024 00:34:46 +0000 (20:34 -0400)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 Aug 2024 18:11:42 +0000 (12:11 -0600)
io_napi_entry() has 2 calling sites. One of them is unlikely to find an
entry and if it does, the timeout should arguable not be updated.

The other io_napi_entry() calling site is overwriting the update made
by io_napi_entry() so the io_napi_entry() timeout value update has no or
little value and therefore is removed.

Signed-off-by: Olivier Langlois <olivier@trillion01.com>
Link: https://lore.kernel.org/r/145b54ff179f87609e20dffaf5563c07cdbcad1a.1723423275.git.olivier@trillion01.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/napi.c

index 73c4159e8405b32810dafe2cb82d5654b5e64bfb..1de1d4d629254c13af841d96c6019c0545ab53f8 100644 (file)
@@ -26,7 +26,6 @@ static struct io_napi_entry *io_napi_hash_find(struct hlist_head *hash_list,
        hlist_for_each_entry_rcu(e, hash_list, node) {
                if (e->napi_id != napi_id)
                        continue;
-               e->timeout = jiffies + NAPI_TIMEOUT;
                return e;
        }