PCI: mvebu: Check that PCI bridge specified in DT has function number zero

Driver cannot handle PCI bridges at non-zero function address. So add
appropriate check. Currently all in-tree kernel DTS files set PCI bridge
function to zero.

Link: https://lore.kernel.org/r/20211125124605.25915-4-pali@kernel.org
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
index e4424db808fe91aac8cff6239623f60632475a6f..2a2100c2e65d54916db7a9160a574d0b77a0a426 100644 (file)
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -845,6 +845,11 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie,
        port->devfn = of_pci_get_devfn(child);
        if (port->devfn < 0)
                goto skip;
+       if (PCI_FUNC(port->devfn) != 0) {
+               dev_err(dev, "%s: invalid function number, must be zero\n",
+                       port->name);
+               goto skip;
+       }
 
        ret = mvebu_get_tgt_attr(dev->of_node, port->devfn, IORESOURCE_MEM,
                                 &port->mem_target, &port->mem_attr);