]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
kheaders: explain why include/config/autoconf.h is excluded from md5sum
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 8 Oct 2019 12:05:56 +0000 (21:05 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:27:10 +0000 (11:27 +0200)
commit f276031b4e2f4c961ed6d8a42f0f0124ccac2e09 upstream.

This comment block explains why include/generated/compile.h is omitted,
but nothing about include/generated/autoconf.h, which might be more
difficult to understand. Add more comments.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/gen_kheaders.sh

index dc5744b93f8c5ba00e19db31c5efabf6cd446c4b..e13ca842eb7eed8232d5938aeb4fa44864d316f9 100755 (executable)
@@ -32,8 +32,15 @@ fi
 all_dirs="$all_dirs $dir_list"
 
 # include/generated/compile.h is ignored because it is touched even when none
-# of the source files changed. This causes pointless regeneration, so let us
-# ignore them for md5 calculation.
+# of the source files changed.
+#
+# When Kconfig regenerates include/generated/autoconf.h, its timestamp is
+# updated, but the contents might be still the same. When any CONFIG option is
+# changed, Kconfig touches the corresponding timestamp file include/config/*.h.
+# Hence, the md5sum detects the configuration change anyway. We do not need to
+# check include/generated/autoconf.h explicitly.
+#
+# Ignore them for md5 calculation to avoid pointless regeneration.
 headers_md5="$(find $all_dirs -name "*.h"                      |
                grep -v "include/generated/compile.h"   |
                grep -v "include/generated/autoconf.h"  |