]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
riscv: Remove extra variable in patch_text_nosync()
authorSamuel Holland <samuel.holland@sifive.com>
Wed, 27 Mar 2024 16:04:46 +0000 (09:04 -0700)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 26 Jun 2024 14:36:33 +0000 (07:36 -0700)
This cast is superfluous, and is incorrect anyway if compressed
instructions may be present.

Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20240327160520.791322-8-samuel.holland@sifive.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/patch.c

index 830f0650656be37e9e8dbfa3efcaa766f62e8646..5b3f6406e8c44dad160159100fd9cbd2cb8a43f8 100644 (file)
@@ -186,13 +186,11 @@ NOKPROBE_SYMBOL(patch_insn_set);
 
 int patch_text_set_nosync(void *addr, u8 c, size_t len)
 {
-       u32 *tp = addr;
        int ret;
 
-       ret = patch_insn_set(tp, c, len);
-
+       ret = patch_insn_set(addr, c, len);
        if (!ret)
-               flush_icache_range((uintptr_t)tp, (uintptr_t)tp + len);
+               flush_icache_range((uintptr_t)addr, (uintptr_t)addr + len);
 
        return ret;
 }
@@ -224,13 +222,11 @@ NOKPROBE_SYMBOL(patch_insn_write);
 
 int patch_text_nosync(void *addr, const void *insns, size_t len)
 {
-       u32 *tp = addr;
        int ret;
 
-       ret = patch_insn_write(tp, insns, len);
-
+       ret = patch_insn_write(addr, insns, len);
        if (!ret)
-               flush_icache_range((uintptr_t) tp, (uintptr_t) tp + len);
+               flush_icache_range((uintptr_t)addr, (uintptr_t)addr + len);
 
        return ret;
 }