]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
qapi: remove '-q' arg to diff when comparing QAPI output
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 16 Jan 2018 13:42:09 +0000 (13:42 +0000)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 5 Feb 2018 21:53:54 +0000 (19:53 -0200)
When the qapi schema tests fail they merely print that the expected
output didn't match the actual output. This is largely useless when
trying diagnose what went wrong. Removing the '-q' arg to diff
means that it is still silent on successful tests, but when it
fails we'll see details of the incorrect output.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <20180116134217.8725-7-berrange@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
tests/Makefile.include

index ca82e0c0ccfd5739b98823d71f8252e0fae36b8c..3258b9c22aafc0e3551ca85538a2b10d4fe84332 100644 (file)
@@ -917,10 +917,10 @@ $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
                $^ >$*.test.out 2>$*.test.err; \
                echo $$? >$*.test.exit, \
                "TEST","$*.out")
-       @diff -q $(SRC_PATH)/$*.out $*.test.out
+       @diff $(SRC_PATH)/$*.out $*.test.out
        @# Sanitize error messages (make them independent of build directory)
-       @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)/$*.err -
-       @diff -q $(SRC_PATH)/$*.exit $*.test.exit
+       @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff $(SRC_PATH)/$*.err -
+       @diff $(SRC_PATH)/$*.exit $*.test.exit
 
 .PHONY: check-tests/qapi-schema/doc-good.texi
 check-tests/qapi-schema/doc-good.texi: tests/qapi-schema/doc-good.test.texi