]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: phylink: warn if deprecated array-style fixed-link binding is used
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 12 Sep 2025 19:07:16 +0000 (21:07 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 16 Sep 2025 01:15:41 +0000 (18:15 -0700)
The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/cc823d38-2a2c-4c83-9a27-d7f25d61a2de@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phylink.c

index 1988b7d2089a6c4f98deef9b9afa4ce41aef8e7d..1b06805f1bd7db1bfe52e10141600b68cbeb5eb5 100644 (file)
@@ -702,6 +702,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
                        return -EINVAL;
                }
 
+               phylink_warn(pl, "%pfw uses deprecated array-style fixed-link binding!\n",
+                            fwnode);
+
                ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
                                                     prop, ARRAY_SIZE(prop));
                if (!ret) {