]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
drm/amd/amdgpu: Fix missing error return on kzalloc failure
authorColin Ian King <colin.i.king@gmail.com>
Tue, 2 Sep 2025 12:40:50 +0000 (13:40 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 3 Sep 2025 20:27:56 +0000 (16:27 -0400)
Currently the kzalloc failure check just sets reports the failure
and sets the variable ret to -ENOMEM, which is not checked later
for this specific error. Fix this by just returning -ENOMEM rather
than setting ret.

Fixes: 4fb930715468 ("drm/amd/amdgpu: remove redundant host to psp cmd buf allocations")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1ee9d1a0962c13ba5ab7e47d33a80e3b8dc4b52e)

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

index 23484317a5fa3bd161844e8f6c631a1b7231e68e..693357caa9a8d7fcaf1794f81c06ad2d93572501 100644 (file)
@@ -448,7 +448,7 @@ static int psp_sw_init(struct amdgpu_ip_block *ip_block)
        psp->cmd = kzalloc(sizeof(struct psp_gfx_cmd_resp), GFP_KERNEL);
        if (!psp->cmd) {
                dev_err(adev->dev, "Failed to allocate memory to command buffer!\n");
-               ret = -ENOMEM;
+               return -ENOMEM;
        }
 
        adev->psp.xgmi_context.supports_extended_data =