goto done;
                buf[1] &= ~DS1305_AEI0;
        }
-       err = spi_write_then_read(ds1305->spi, buf, sizeof buf, NULL, 0);
+       err = spi_write_then_read(ds1305->spi, buf, sizeof(buf), NULL, 0);
        if (err >= 0)
                ds1305->ctrl[0] = buf[1];
 done:
        /* Use write-then-read to get all the date/time registers
         * since dma from stack is nonportable
         */
-       status = spi_write_then_read(ds1305->spi, &addr, sizeof addr,
-                       buf, sizeof buf);
+       status = spi_write_then_read(ds1305->spi, &addr, sizeof(addr),
+                       buf, sizeof(buf));
        if (status < 0)
                return status;
 
                buf[4], buf[5], buf[6], buf[7]);
 
        /* use write-then-read since dma from stack is nonportable */
-       return spi_write_then_read(ds1305->spi, buf, sizeof buf,
+       return spi_write_then_read(ds1305->spi, buf, sizeof(buf),
                        NULL, 0);
 }
 
         * of EFI status is at best fragile anyway (given IRQ handlers).
         */
        addr = DS1305_CONTROL;
-       status = spi_write_then_read(spi, &addr, sizeof addr,
-                       ds1305->ctrl, sizeof ds1305->ctrl);
+       status = spi_write_then_read(spi, &addr, sizeof(addr),
+                       ds1305->ctrl, sizeof(ds1305->ctrl));
        if (status < 0)
                return status;
 
 
        /* get and check ALM0 registers */
        addr = DS1305_ALM0(DS1305_SEC);
-       status = spi_write_then_read(spi, &addr, sizeof addr,
-                       buf, sizeof buf);
+       status = spi_write_then_read(spi, &addr, sizeof(addr),
+                       buf, sizeof(buf));
        if (status < 0)
                return status;
 
                "alm0 write", buf[1 + DS1305_SEC], buf[1 + DS1305_MIN],
                buf[1 + DS1305_HOUR], buf[1 + DS1305_WDAY]);
 
-       status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
+       status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
        if (status < 0)
                return status;
 
        buf[1] = ds1305->ctrl[0];
        buf[2] = 0;
 
-       status = spi_write_then_read(spi, buf, sizeof buf,
+       status = spi_write_then_read(spi, buf, sizeof(buf),
                        NULL, 0);
        if (status < 0)
                dev_dbg(&spi->dev, "clear irq --> %d\n", status);
 
        /* read and cache control registers */
        addr = DS1305_CONTROL;
-       status = spi_write_then_read(spi, &addr, sizeof addr,
-                       ds1305->ctrl, sizeof ds1305->ctrl);
+       status = spi_write_then_read(spi, &addr, sizeof(addr),
+                       ds1305->ctrl, sizeof(ds1305->ctrl));
        if (status < 0) {
                dev_dbg(&spi->dev, "can't %s, %d\n",
                                "read", status);
 
                buf[0] = DS1305_WRITE | DS1305_CONTROL;
                buf[1] = ds1305->ctrl[0];
-               status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
+               status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
 
                dev_dbg(&spi->dev, "clear WP --> %d\n", status);
                if (status < 0)
                buf[1] = ds1305->ctrl[0];
                buf[2] = ds1305->ctrl[1];
                buf[3] = ds1305->ctrl[2];
-               status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
+               status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
                if (status < 0) {
                        dev_dbg(&spi->dev, "can't %s, %d\n",
                                        "write", status);
 
        /* see if non-Linux software set up AM/PM mode */
        addr = DS1305_HOUR;
-       status = spi_write_then_read(spi, &addr, sizeof addr,
-                               &value, sizeof value);
+       status = spi_write_then_read(spi, &addr, sizeof(addr),
+                               &value, sizeof(value));
        if (status < 0) {
                dev_dbg(&spi->dev, "read HOUR --> %d\n", status);
                return status;