]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
be2net: remove redundant initialization of 'head' and pointer txq
authorColin Ian King <colin.king@canonical.com>
Wed, 31 Jan 2018 16:14:25 +0000 (16:14 +0000)
committerJack Vogel <jack.vogel@oracle.com>
Fri, 9 Mar 2018 00:27:22 +0000 (16:27 -0800)
Orabug: 27615319

Variable head is initialized to a value that is never read and is
being updated to a new value a few lines later, hence this
initialization is redundant and can be safely removed as well
as the now unused pointer txq.

Cleans up clang warning:
drivers/net/ethernet/emulex/benet/be_main.c:996:6: warning: Value
stored to 'head' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 2e85283dabc22f4715b136e8a7426bd9bef4ce69)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/ethernet/emulex/benet/be_main.c

index 52594148d23e0f1602404c753fde1d12feabeafc..bb29587154660079768a97a664217ce30c5e872f 100644 (file)
@@ -993,9 +993,8 @@ static u32 be_xmit_enqueue(struct be_adapter *adapter, struct be_tx_obj *txo,
 {
        u32 i, copied = 0, wrb_cnt = skb_wrb_cnt(skb);
        struct device *dev = &adapter->pdev->dev;
-       struct be_queue_info *txq = &txo->q;
        bool map_single = false;
-       u32 head = txq->head;
+       u32 head;
        dma_addr_t busaddr;
        int len;