mwifiex: drop 'add_tail' param from mwifiex_insert_cmd_to_pending_q()

It's always called with 'true' -- we only determine it 'false' locally
within this function. So drop the parameter.

Also, this should be 'bool' (since we use true/false), not 'u32'.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index 6ff8e84b01e02a7dc5b4558c6dee4bd56ac59292..3f5e822673bf01e1174bbfc301fd91485327cfa1 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -664,7 +664,7 @@ int mwifiex_send_cmd(struct mwifiex_private *priv, u16 cmd_no,
            cmd_no == HostCmd_CMD_802_11_SCAN_EXT) {
                mwifiex_queue_scan_cmd(priv, cmd_node);
        } else {
-               mwifiex_insert_cmd_to_pending_q(adapter, cmd_node, true);
+               mwifiex_insert_cmd_to_pending_q(adapter, cmd_node);
                queue_work(adapter->workqueue, &adapter->main_work);
                if (cmd_node->wait_q_enabled)
                        ret = mwifiex_wait_queue_complete(adapter, cmd_node);
@@ -682,11 +682,12 @@ int mwifiex_send_cmd(struct mwifiex_private *priv, u16 cmd_no,
  */
 void
 mwifiex_insert_cmd_to_pending_q(struct mwifiex_adapter *adapter,
-                               struct cmd_ctrl_node *cmd_node, u32 add_tail)
+                               struct cmd_ctrl_node *cmd_node)
 {
        struct host_cmd_ds_command *host_cmd = NULL;
        u16 command;
        unsigned long flags;
+       bool add_tail = true;
 
        host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
        if (!host_cmd) {

diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
index 2bee5cdf1fc80e4f11eb2da50f13f841a0639d53..909bd1ad3838a5c4ddf642d56c8f6c99c8ed35eb 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/main.h
+++ b/drivers/net/wireless/marvell/mwifiex/main.h
@@ -1088,8 +1088,7 @@ void mwifiex_recycle_cmd_node(struct mwifiex_adapter *adapter,
                              struct cmd_ctrl_node *cmd_node);
 
 void mwifiex_insert_cmd_to_pending_q(struct mwifiex_adapter *adapter,
-                                    struct cmd_ctrl_node *cmd_node,
-                                    u32 addtail);
+                                    struct cmd_ctrl_node *cmd_node);
 
 int mwifiex_exec_next_cmd(struct mwifiex_adapter *adapter);
 int mwifiex_process_cmdresp(struct mwifiex_adapter *adapter);

diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index 9900855746acdc8cd3de299be78a3e6f781719a0..d8e8b857ddfbf761e9d11335e07cafd009cf2789 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -1534,8 +1534,7 @@ int mwifiex_scan_networks(struct mwifiex_private *priv,
                        list_del(&cmd_node->list);
                        spin_unlock_irqrestore(&adapter->scan_pending_q_lock,
                                               flags);
-                       mwifiex_insert_cmd_to_pending_q(adapter, cmd_node,
-                                                       true);
+                       mwifiex_insert_cmd_to_pending_q(adapter, cmd_node);
                        queue_work(adapter->workqueue, &adapter->main_work);
 
                        /* Perform internal scan synchronously */
@@ -2033,7 +2032,7 @@ static void mwifiex_check_next_scan_command(struct mwifiex_private *priv)
                                            struct cmd_ctrl_node, list);
                list_del(&cmd_node->list);
                spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
-               mwifiex_insert_cmd_to_pending_q(adapter, cmd_node, true);
+               mwifiex_insert_cmd_to_pending_q(adapter, cmd_node);
        }
 
        return;