]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: codecs: wcd939x: get regmap directly
authorSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Tue, 9 Sep 2025 12:19:51 +0000 (13:19 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 18 Sep 2025 21:24:33 +0000 (22:24 +0100)
for some reason we ended up with a boiler plate for dev_get_regmap in
wcd939x codec and started exporting a symbol for this. Remove this
redundant wrapper and direclty get regmap.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20250909121954.225833-11-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd939x-sdw.c
sound/soc/codecs/wcd939x.c
sound/soc/codecs/wcd939x.h

index 6aecad2a28aaaeb92f7832d8e146845ccdff1bb8..38da706d80be1571aaac50c65d2ff80c84a35ef2 100644 (file)
@@ -187,15 +187,6 @@ int wcd939x_sdw_set_sdw_stream(struct wcd939x_sdw_priv *wcd,
 }
 EXPORT_SYMBOL_GPL(wcd939x_sdw_set_sdw_stream);
 
-struct regmap *wcd939x_swr_get_regmap(struct wcd939x_sdw_priv *wcd)
-{
-       if (wcd->regmap)
-               return wcd->regmap;
-
-       return ERR_PTR(-EINVAL);
-}
-EXPORT_SYMBOL_GPL(wcd939x_swr_get_regmap);
-
 static int wcd9390_update_status(struct sdw_slave *slave,
                                 enum sdw_slave_status status)
 {
index a414cd99b9466a57d18b0a48cc3bab900c178d70..e74e6f0131318c9f5041e844e2a2753f5a8c6c32 100644 (file)
@@ -3374,10 +3374,10 @@ static int wcd939x_bind(struct device *dev)
        }
 
        /* Get regmap from TX SoundWire device */
-       wcd939x->regmap = wcd939x_swr_get_regmap(wcd939x->sdw_priv[AIF1_CAP]);
-       if (IS_ERR(wcd939x->regmap)) {
+       wcd939x->regmap = wcd939x->sdw_priv[AIF1_CAP]->regmap;
+       if (!wcd939x->regmap) {
                dev_err(dev, "could not get TX device regmap\n");
-               ret = PTR_ERR(wcd939x->regmap);
+               ret = -ENODEV;
                goto err_remove_rx_link;
        }
 
index ca6353222ea01ed9137044bb6fa41b61cd39094b..6bd2366587a8f116254b81df9d1f971c5a618db7 100644 (file)
@@ -918,8 +918,6 @@ int wcd939x_sdw_hw_params(struct wcd939x_sdw_priv *wcd,
                          struct snd_pcm_substream *substream,
                          struct snd_pcm_hw_params *params,
                          struct snd_soc_dai *dai);
-
-struct regmap *wcd939x_swr_get_regmap(struct wcd939x_sdw_priv *wcd);
 #else
 
 static inline int wcd939x_sdw_free(struct wcd939x_sdw_priv *wcd,
@@ -944,10 +942,6 @@ static inline int wcd939x_sdw_hw_params(struct wcd939x_sdw_priv *wcd,
        return -EOPNOTSUPP;
 }
 
-struct regmap *wcd939x_swr_get_regmap(struct wcd939x_sdw_priv *wcd)
-{
-       return PTR_ERR(-EINVAL);
-}
 #endif /* CONFIG_SND_SOC_WCD939X_SDW */
 
 #endif /* __WCD939X_H__ */