]> www.infradead.org Git - users/hch/misc.git/commitdiff
HID: winwing: Add NULL check in winwing_init_led()
authorCharles Han <hanchunchao@inspur.com>
Thu, 14 Nov 2024 09:19:47 +0000 (17:19 +0800)
committerJiri Kosina <jkosina@suse.com>
Mon, 3 Feb 2025 21:47:32 +0000 (22:47 +0100)
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in winwing_init_led() is not checked.
Add NULL check in winwing_init_led(), to handle kernel NULL
pointer dereference error.

Fixes: 266c990debad ("HID: Add WinWing Orion2 throttle support")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-winwing.c

index 831b760c66ea7273abfc8134861c20caa45d56a6..d4afbbd2780797fecee4338e1c0f33e13fded2b5 100644 (file)
@@ -106,6 +106,8 @@ static int winwing_init_led(struct hid_device *hdev,
                                                "%s::%s",
                                                dev_name(&input->dev),
                                                info->led_name);
+               if (!led->cdev.name)
+                       return -ENOMEM;
 
                ret = devm_led_classdev_register(&hdev->dev, &led->cdev);
                if (ret)