]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: codecs: wcdxxxx: use sdw_slave_get_current_bank helper
authorSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Tue, 9 Sep 2025 12:19:47 +0000 (13:19 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 18 Sep 2025 21:24:29 +0000 (22:24 +0100)
use sdw_slave_get_current_bank() helper function, rather than duplicating
this function in every codec driver.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Link: https://patch.msgid.link/20250909121954.225833-7-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd938x-sdw.c
sound/soc/codecs/wcd938x.c
sound/soc/codecs/wcd938x.h
sound/soc/codecs/wcd939x-sdw.c
sound/soc/codecs/wcd939x.c
sound/soc/codecs/wcd939x.h

index a7514d716086ca533e369f37053ffbdf5b01a63f..8bcd8396f3750a4677464787befaeac92bf256bf 100644 (file)
@@ -82,16 +82,6 @@ static struct sdw_dpn_prop wcd938x_dpn_prop[WCD938X_MAX_SWR_PORTS] = {
        }
 };
 
-int wcd938x_swr_get_current_bank(struct sdw_slave *sdev)
-{
-       int bank;
-
-       bank  = sdw_read(sdev, SDW_SCP_CTRL);
-
-       return ((bank & 0x40) ? 1 : 0);
-}
-EXPORT_SYMBOL_GPL(wcd938x_swr_get_current_bank);
-
 int wcd938x_sdw_hw_params(struct wcd938x_sdw_priv *wcd,
                          struct snd_pcm_substream *substream,
                          struct snd_pcm_hw_params *params,
index e2cb0758bca7909c55ed1cf616761c817d37a70c..f8d7bf27a6edbcad5e6d19c8d01eeb36151e7d5d 100644 (file)
@@ -1094,8 +1094,7 @@ static int wcd938x_tx_swr_ctrl(struct snd_soc_dapm_widget *w,
        int bank;
        int rate;
 
-       bank = (wcd938x_swr_get_current_bank(wcd938x->sdw_priv[AIF1_CAP]->sdev)) ? 0 : 1;
-       bank = bank ? 0 : 1;
+       bank = sdw_slave_get_current_bank(wcd938x->sdw_priv[AIF1_CAP]->sdev);
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
index dbafcae247f4fb8be95492031a78fa794770e01a..54ee56b7fbd6ab7782d950d19ef866444020d321 100644 (file)
@@ -669,9 +669,6 @@ int wcd938x_sdw_hw_params(struct wcd938x_sdw_priv *wcd,
                          struct snd_pcm_substream *substream,
                          struct snd_pcm_hw_params *params,
                          struct snd_soc_dai *dai);
-
-int wcd938x_swr_get_current_bank(struct sdw_slave *sdev);
-
 #else
 
 static inline int wcd938x_sdw_free(struct wcd938x_sdw_priv *wcd,
@@ -696,9 +693,5 @@ static inline int wcd938x_sdw_hw_params(struct wcd938x_sdw_priv *wcd,
        return -EOPNOTSUPP;
 }
 
-static inline int wcd938x_swr_get_current_bank(struct sdw_slave *sdev)
-{
-       return 0;
-}
 #endif /* CONFIG_SND_SOC_WCD938X_SDW */
 #endif /* __WCD938X_H__ */
index e487a1bb0194e1917d8a45fda2d69248d5e83e07..477d6cf27d32c349aee6ed211c4c44eefa77de97 100644 (file)
@@ -128,13 +128,6 @@ static struct sdw_dpn_prop wcd939x_tx_dpn_prop[WCD939X_MAX_TX_SWR_PORTS] = {
        }
 };
 
-unsigned int wcd939x_swr_get_current_bank(struct sdw_slave *sdev)
-{
-       return FIELD_GET(SDW_SCP_STAT_CURR_BANK,
-                        sdw_read(sdev, SDW_SCP_CTRL));
-}
-EXPORT_SYMBOL_GPL(wcd939x_swr_get_current_bank);
-
 int wcd939x_sdw_hw_params(struct wcd939x_sdw_priv *wcd,
                          struct snd_pcm_substream *substream,
                          struct snd_pcm_hw_params *params,
index 5a56c79a89227791c364ab7c1242c5fb2116f22c..85730ae40c2c2424161adc52173594689d24f4f6 100644 (file)
@@ -1017,7 +1017,7 @@ static int wcd939x_tx_swr_ctrl(struct snd_soc_dapm_widget *w,
        int bank;
        int rate;
 
-       bank = wcd939x_swr_get_current_bank(wcd939x->sdw_priv[AIF1_CAP]->sdev);
+       bank = sdw_slave_get_current_bank(wcd939x->sdw_priv[AIF1_CAP]->sdev);
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
index 3f189e5cafd51719021fd77bbcd9aa4e1c61a351..e70445b1a4bc8ad6313a06ed4c754418ce37fa72 100644 (file)
@@ -930,8 +930,6 @@ int wcd939x_sdw_hw_params(struct wcd939x_sdw_priv *wcd,
                          struct snd_pcm_hw_params *params,
                          struct snd_soc_dai *dai);
 
-unsigned int wcd939x_swr_get_current_bank(struct sdw_slave *sdev);
-
 struct regmap *wcd939x_swr_get_regmap(struct wcd939x_sdw_priv *wcd);
 #else
 
@@ -957,11 +955,6 @@ static inline int wcd939x_sdw_hw_params(struct wcd939x_sdw_priv *wcd,
        return -EOPNOTSUPP;
 }
 
-static inline unsigned int wcd939x_swr_get_current_bank(struct sdw_slave *sdev)
-{
-       return 0;
-}
-
 struct regmap *wcd939x_swr_get_regmap(struct wcd939x_sdw_priv *wcd)
 {
        return PTR_ERR(-EINVAL);