]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: atomisp: Disable broken V4L2_PIX_FMT_RGBX32 output support
authorHans de Goede <hdegoede@redhat.com>
Sat, 16 Mar 2024 21:53:06 +0000 (21:53 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 26 Apr 2024 09:09:45 +0000 (10:09 +0100)
Disable V4L2_PIX_FMT_RGBX32 support, because it is broken.

Selecting V4L2_PIX_FMT_RGBX32 output shows vertical columns with random
data. For each 128 pixels in a row the last 28 (32?) or so pixels contain
random data.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c

index 9d87213a8382aca59d378ae51916600045b30d67..756f70ac073b979f432f01946b9acd4af54503c8 100644 (file)
@@ -300,12 +300,6 @@ const struct atomisp_format_bridge atomisp_output_fmts[] = {
                .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
                .sh_fmt = IA_CSS_FRAME_FORMAT_RAW,
                .description = "Bayer 12"
-       }, {
-               .pixelformat = V4L2_PIX_FMT_RGBX32,
-               .depth = 32,
-               .mbus_code = V4L2_MBUS_FMT_CUSTOM_RGB32,
-               .sh_fmt = IA_CSS_FRAME_FORMAT_RGBA888,
-               .description = "32 RGB 8-8-8-8"
        }, {
                .pixelformat = V4L2_PIX_FMT_RGB565,
                .depth = 16,
@@ -313,6 +307,17 @@ const struct atomisp_format_bridge atomisp_output_fmts[] = {
                .sh_fmt = IA_CSS_FRAME_FORMAT_RGB565,
                .description = "16 RGB 5-6-5"
 #if 0
+       }, {
+               /*
+                * Broken, showing vertical columns with random data.
+                * For each 128 pixels in a row the last 28 (32?) or so pixels
+                * contain random data.
+                */
+               .pixelformat = V4L2_PIX_FMT_RGBX32,
+               .depth = 32,
+               .mbus_code = V4L2_MBUS_FMT_CUSTOM_RGB32,
+               .sh_fmt = IA_CSS_FRAME_FORMAT_RGBA888,
+               .description = "32 RGB 8-8-8-8"
        }, {
                .pixelformat = V4L2_PIX_FMT_JPEG,
                .depth = 8,