]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
platform/x86/amd: pmf: Fix missing hidden options for Smart PC
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 6 Mar 2025 03:44:02 +0000 (21:44 -0600)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 13 Mar 2025 12:53:33 +0000 (14:53 +0200)
amd_pmf_get_slider_info() checks the current profile to report correct
value to the TA inputs.  If hidden options are in use then the wrong
values will be reported to TA.

Add the two compat options PLATFORM_PROFILE_BALANCED_PERFORMANCE and
PLATFORM_PROFILE_QUIET for this use.

Reported-by: Yijun Shen <Yijun.Shen@dell.com>
Fixes: 9a43102daf64d ("platform/x86/amd: pmf: Add balanced-performance to hidden choices")
Fixes: 44e94fece5170 ("platform/x86/amd: pmf: Add 'quiet' to hidden choices")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20250306034402.50478-1-superm1@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmf/spc.c

index f34f3130c3307e72d8dc6adf2540a9c298f32cd9..1d90f9382024b08cd1d3c3fdc9852b470237d7de 100644 (file)
@@ -219,12 +219,14 @@ static int amd_pmf_get_slider_info(struct amd_pmf_dev *dev, struct ta_pmf_enact_
 
        switch (dev->current_profile) {
        case PLATFORM_PROFILE_PERFORMANCE:
+       case PLATFORM_PROFILE_BALANCED_PERFORMANCE:
                val = TA_BEST_PERFORMANCE;
                break;
        case PLATFORM_PROFILE_BALANCED:
                val = TA_BETTER_PERFORMANCE;
                break;
        case PLATFORM_PROFILE_LOW_POWER:
+       case PLATFORM_PROFILE_QUIET:
                val = TA_BEST_BATTERY;
                break;
        default: