block: avoid possible overflow for chunk_sectors check in blk_stack_limits()

In blk_stack_limits(), we check that the t->chunk_sectors value is a
multiple of the t->physical_block_size value.

However, by finding the chunk_sectors value in bytes, we may overflow
the unsigned int which holds chunk_sectors, so change the check to be
based on sectors.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250729091448.1691334-2-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 608df4674245ae7b8c87e8a2a6a4ff0aa264cd64..bb192d776bdb803c8937406ceb6175e7560d6ee4 100644 (file)
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -857,7 +857,7 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
        }
 
        /* chunk_sectors a multiple of the physical block size? */
-       if ((t->chunk_sectors << 9) & (t->physical_block_size - 1)) {
+       if (t->chunk_sectors % (t->physical_block_size >> SECTOR_SHIFT)) {
                t->chunk_sectors = 0;
                t->flags |= BLK_FLAG_MISALIGNED;
                ret = -1;