]> www.infradead.org Git - mtd-utils.git/commitdiff
mtd-utils: tests: Avoid using less than two blocks in nandpagetest
authorMiquel Raynal <miquel.raynal@free-electrons.com>
Thu, 24 Aug 2017 10:59:46 +0000 (12:59 +0200)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Thu, 24 Aug 2017 11:00:58 +0000 (13:00 +0200)
Forbid the use of less than 2 eraseblocks in nandpagetest. It is obvious
that the test cannot run on zero block, but it cannot run on only one
block neither. The reason is: get_first_and_last_block() will return the
same id for both the first and the last blocks. In erasecrosstest(),
the logic is:
- erase/write/read/verify first block
- erase/write again first block
- erase *last* block
- read/verify first block
When using only one block, 'first' refers to the same block as 'last',
leading to erasing the block before reading it. Hence, the test would
fail with no actual reason.

Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
tests/mtd-tests/nandpagetest.c

index 4145ef79231291ae74841b7306606776f4724a4a..86c900598f2bf98e4f4fc5df5034ef2df7274ba9 100644 (file)
@@ -65,7 +65,7 @@ static void usage(int status)
        "Options:\n"
        "  -h, --help         Display this help output\n"
        "  -b, --peb <num>    Index of the first erase block to use\n"
-       "  -c, --count <num>  Number of erase blocks to use (default all)\n"
+       "  -c, --count <num>  Number of erase blocks to use (at least 2, default all)\n"
        "  -s, --skip <num>   Number of erase blocks to skip\n"
        "  -S, --seed <num>   Seed for pseudor random number generator\n"
        "  -k, --keep         Restore existing contents after test\n",
@@ -143,6 +143,8 @@ static void process_options(int argc, char **argv)
 
        if (optind < argc)
                usage(EXIT_FAILURE);
+       if (ebcnt < 2)
+               errmsg_die("Cannot run with less than two blocks.");
        if (peb < 0)
                peb = 0;
        if (!(flags & SEED_SET))