]> www.infradead.org Git - users/hch/misc.git/commitdiff
PCI: Alter misleading recursion to pci_bus_release_bridge_resources()
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 29 Aug 2025 13:11:13 +0000 (16:11 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 16 Sep 2025 16:20:09 +0000 (11:20 -0500)
Recursing into pci_bus_release_bridge_resources() should not alter rel_type
because it makes no sense to change the release type within the recursion
call chain. A literal "whole_subtree" is passed into the recursion instead
of "rel_type" parameter which is misleading as the release type should
remain the same throughout the entire operation.

This is not a correctness issue because of the preceding if () that only
allows the recursion to happen if rel_type is "whole_subtree". Still,
replace the non-intuitive parameter with direct passing of "rel_type".

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20250829131113.36754-25-ilpo.jarvinen@linux.intel.com
drivers/pci/setup-bus.c

index 4ce747b5dea33ed6bd34c0a198c439ba98ee2b7d..d264f16772b9ce4c71b87484f8e0a0739dc65657 100644 (file)
@@ -1855,7 +1855,7 @@ static void pci_bus_release_bridge_resources(struct pci_bus *bus,
                        if (res->parent != b_win)
                                continue;
 
-                       pci_bus_release_bridge_resources(b, res, whole_subtree);
+                       pci_bus_release_bridge_resources(b, res, rel_type);
                }
        }