]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
virtio-pci: fix proxy->vector_irqfd leak in virtio_pci_set_guest_notifiers
authorleixiang <leixiang@kylinos.cn>
Tue, 27 Dec 2022 08:16:04 +0000 (16:16 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 8 Jan 2023 06:54:23 +0000 (01:54 -0500)
proxy->vector_irqfd did not free when kvm_virtio_pci_vector_use or
msix_set_vector_notifiers failed in virtio_pci_set_guest_notifiers.

Fixes: 7d37d351
Signed-off-by: Lei Xiang <leixiang@kylinos.cn>
Tested-by: Zeng Chi <zengchi@kylinos.cn>
Suggested-by: Xie Ming <xieming@kylinos.cn>
Message-Id: <20221227081604.806415-1-leixiang@kylinos.cn>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/virtio-pci.c

index 7bc60fcf941f3c0e30d113fd69362f53bdfc51a5..247325c1933ca5cd503a40b8652cb44ec0ac41f3 100644 (file)
@@ -1291,6 +1291,8 @@ assign_error:
     while (--n >= 0) {
         virtio_pci_set_guest_notifier(d, n, !assign, with_irqfd);
     }
+    g_free(proxy->vector_irqfd);
+    proxy->vector_irqfd = NULL;
     return r;
 }