]> www.infradead.org Git - users/hch/misc.git/commitdiff
module: Remove module_assert_mutex_or_preempt() from try_add_tainted_module().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 8 Jan 2025 09:04:38 +0000 (10:04 +0100)
committerPetr Pavlu <petr.pavlu@suse.com>
Mon, 10 Mar 2025 10:54:44 +0000 (11:54 +0100)
module_assert_mutex_or_preempt() is not needed in
try_add_tainted_module(). The function checks for RCU-sched or the
module_mutex to be acquired. The list_for_each_entry_rcu() below does
the same check.

Remove module_assert_mutex_or_preempt() from try_add_tainted_module().

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250108090457.512198-10-bigeasy@linutronix.de
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
kernel/module/tracking.c

index 16742d1c630c677f150bbdb0a3f27af82bdb14e1..4fefec5b683c600803629ac8cded5e711cdb7177 100644 (file)
@@ -21,8 +21,6 @@ int try_add_tainted_module(struct module *mod)
 {
        struct mod_unload_taint *mod_taint;
 
-       module_assert_mutex_or_preempt();
-
        if (!mod->taints)
                goto out;