]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
HID: lenovo: Restrict detection of patched firmware only to USB cptkbd
authorMikhail Khvainitski <me@khvoinitsky.org>
Tue, 12 Dec 2023 13:31:48 +0000 (15:31 +0200)
committerJiri Kosina <jkosina@suse.com>
Tue, 12 Dec 2023 13:45:34 +0000 (14:45 +0100)
Commit 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and
stop applying workaround") introduced a regression for ThinkPad
TrackPoint Keyboard II which has similar quirks to cptkbd (so it uses
the same workarounds) but slightly different so that there are
false-positives during detecting well-behaving firmware. This commit
restricts detecting well-behaving firmware to the only model which
known to have one and have stable enough quirks to not cause
false-positives.

Fixes: 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround")
Link: https://lore.kernel.org/linux-input/ZXRiiPsBKNasioqH@jekhomev/
Link: https://bbs.archlinux.org/viewtopic.php?pid=2135468#p2135468
Signed-off-by: Mikhail Khvainitski <me@khvoinitsky.org>
Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-lenovo.c

index 7c1b33be9d1343e90a75651daa2b9afc163c5656..149a3c74346b4f28b0f97fba19b99427e85cd89a 100644 (file)
@@ -692,7 +692,8 @@ static int lenovo_event_cptkbd(struct hid_device *hdev,
                 * so set middlebutton_state to 3
                 * to never apply workaround anymore
                 */
-               if (cptkbd_data->middlebutton_state == 1 &&
+               if (hdev->product == USB_DEVICE_ID_LENOVO_CUSBKBD &&
+                               cptkbd_data->middlebutton_state == 1 &&
                                usage->type == EV_REL &&
                                (usage->code == REL_X || usage->code == REL_Y)) {
                        cptkbd_data->middlebutton_state = 3;