]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
RDS: IB: Make use of ARPOP_REQUEST instead of ARPOP_REPLY in bonding code
authorSantosh Shilimkar <santosh.shilimkar@oracle.com>
Mon, 18 Apr 2016 14:09:39 +0000 (07:09 -0700)
committerSantosh Shilimkar <santosh.shilimkar@oracle.com>
Fri, 27 May 2016 16:31:17 +0000 (09:31 -0700)
Even though IPv4 ARP RFC allows for using either REQUEST or REPLY
for grat. arp, upstream code from 3.14 onwards have moved on to
use only REQUEST.

Relevant commit:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=56022a8fdd874c56bb61d8c82559e43044d1aa06

RDS active bonding gratuitous arp code needs to adopt to this change
to take advantage of the neighbor updates on UEK4. The current code
makes use  ARPOP_REPLY which needs to be changed to ARPOP_REQUEST.

Orabug: 23094704

Tested-by: Michael Nowak <michael.nowak@oracle.com>
Tested-by: Rose Wang <rose.wang@oracle.com>
Tested-by: Rafael Alejandro Peralez <rafael.peralez@oracle.com>
Acked-by: Mukesh Kacker <mukesh.kacker@oracle.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Reported-by: Mukesh Kacker <mukesh.kacker@oracle.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
net/rds/ib.c

index 19cf1ae6b22e323bea7dfe13902c0d0fb408296b..1e69e67885daaf4697e09086f03e16cd2359e2d2 100644 (file)
@@ -508,7 +508,7 @@ static void rds_ib_send_gratuitous_arp(struct net_device    *out_dev,
 
        /* Send multiple ARPs to improve reliability */
        for (i = 0; i < rds_ib_active_bonding_arps; i++) {
-               arp_send(ARPOP_REPLY, ETH_P_ARP,
+               arp_send(ARPOP_REQUEST, ETH_P_ARP,
                        ip_addr, out_dev,
                        ip_addr, NULL,
                        dev_addr, NULL);