iwlwifi: pcie: restart the driver when a command times out

This should really not happen. If it does, restarting is the
only way to recover since the driver and the firmware might
very well be out of sync. Moreover, iwl_op_mode_nic_error
will print data that might help debugging.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/iwlwifi/pcie/tx.c b/drivers/net/wireless/iwlwifi/pcie/tx.c
index a70a30e2aeb0c0165279ed191e093a98b7a373c4..b4168415538c592ea9dd84ab4e8006eceeb1fc56 100644 (file)
--- a/drivers/net/wireless/iwlwifi/pcie/tx.c
+++ b/drivers/net/wireless/iwlwifi/pcie/tx.c
@@ -1529,7 +1529,6 @@ static int iwl_pcie_send_hcmd_sync(struct iwl_trans *trans,
                                "Error sending %s: time out after %dms.\n",
                                get_cmd_string(trans_pcie, cmd->id),
                                jiffies_to_msecs(HOST_COMPLETE_TIMEOUT));
-                       dump_stack();
 
                        IWL_ERR(trans,
                                "Current CMD queue read_ptr %d write_ptr %d\n",
@@ -1540,6 +1539,9 @@ static int iwl_pcie_send_hcmd_sync(struct iwl_trans *trans,
                                       "Clearing HCMD_ACTIVE for command %s\n",
                                       get_cmd_string(trans_pcie, cmd->id));
                        ret = -ETIMEDOUT;
+
+                       iwl_op_mode_nic_error(trans->op_mode);
+
                        goto cancel;
                }
        }