]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i40evf: remove unnecessary error checking against i40e_shutdown_adminq
authorLihong Yang <lihong.yang@intel.com>
Wed, 7 Sep 2016 01:05:05 +0000 (18:05 -0700)
committerDhaval Giani <dhaval.giani@oracle.com>
Wed, 8 Mar 2017 00:39:28 +0000 (19:39 -0500)
Orabug: 24568124

The i40e_shutdown_adminq function never returns failure. There is no need to
check the non-0 return value. Clean up the unnecessary error checking and
warning against it.

Change-ID: Ibb616f09cfb93bd1a872ebf3241a15fb8354b31b
Signed-off-by: Lihong Yang <lihong.yang@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit 903e68323bb62cc8ca30c5a7a41d962f92c27b97)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/net/ethernet/intel/i40evf/i40evf_main.c

index 7b83b79d8593a47a3d85c9579731a53a971192a5..126b96616691ce63eab01c6871f92b627f9fb363 100644 (file)
@@ -1785,8 +1785,7 @@ continue_reset:
        i40evf_free_all_tx_resources(adapter);
 
        /* kill and reinit the admin queue */
-       if (i40evf_shutdown_adminq(hw))
-               dev_warn(&adapter->pdev->dev, "Failed to shut down adminq\n");
+       i40evf_shutdown_adminq(hw);
        adapter->current_op = I40E_VIRTCHNL_OP_UNKNOWN;
        err = i40evf_init_adminq(hw);
        if (err)