]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
genirq: Fix misleading synchronize_irq() documentation
authorThomas Gleixner <tglx@linutronix.de>
Fri, 28 Jun 2019 11:11:50 +0000 (13:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Jul 2019 07:00:39 +0000 (09:00 +0200)
commit 1d21f2af8571c6a6a44e7c1911780614847b0253 upstream.

The function might sleep, so it cannot be called from interrupt
context. Not even with care.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/20190628111440.189241552@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/irq/manage.c

index 54a41da65eb35c34e6a085187acc9067b76f3c1a..df8498dcb3920fac010f00b6d1ea3f686ad5d645 100644 (file)
@@ -96,7 +96,8 @@ EXPORT_SYMBOL(synchronize_hardirq);
  *     to complete before returning. If you use this function while
  *     holding a resource the IRQ handler may need you will deadlock.
  *
- *     This function may be called - with care - from IRQ context.
+ *     Can only be called from preemptible code as it might sleep when
+ *     an interrupt thread is associated to @irq.
  */
 void synchronize_irq(unsigned int irq)
 {