]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/bridge: adv7511: Remove a redundant check on existence of bridge->encoder
authorSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 13 May 2024 15:31:03 +0000 (23:31 +0800)
committerRobert Foss <rfoss@kernel.org>
Mon, 13 May 2024 16:31:05 +0000 (18:31 +0200)
In the adv7511_connector_init() function, the check on the existence of
bridge->encoder is not necessary. As it has already been checked in the
drm_bridge_attach() which happens prior to the adv7511_bridge_attach()
get called. Also note that the adv7511_connector_init() is only called by
adv7511_bridge_attach(). Hence, it is guaranteed that the .encoder member
of the drm_bridge instance is not NULL when adv7511_connector_init() get
called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-7-sui.jingfeng@linux.dev
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

index dd21b81bd28f9e83d01d00007646f5a128acb28e..6089b0bb932122d63e30d8a7121d45068499bc02 100644 (file)
@@ -877,11 +877,6 @@ static int adv7511_connector_init(struct adv7511 *adv)
        struct drm_bridge *bridge = &adv->bridge;
        int ret;
 
-       if (!bridge->encoder) {
-               DRM_ERROR("Parent encoder object not found");
-               return -ENODEV;
-       }
-
        if (adv->i2c_main->irq)
                adv->connector.polled = DRM_CONNECTOR_POLL_HPD;
        else