]> www.infradead.org Git - users/hch/xfs.git/commitdiff
selftests: net: lib: support errexit with busywait
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Wed, 5 Jun 2024 09:21:16 +0000 (11:21 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Jun 2024 15:29:07 +0000 (08:29 -0700)
If errexit is enabled ('set -e'), loopy_wait -- or busywait and others
using it -- will stop after the first failure.

Note that if the returned status of loopy_wait is checked, and even if
errexit is enabled, Bash will not stop at the first error.

Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Cc: stable@vger.kernel.org
Acked-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20240605-upstream-net-20240605-selftests-net-lib-fixes-v1-1-b3afadd368c9@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib.sh

index edc030e81a4649e5245c6bc1a336f3c83c28daed..a422e10d3d3a0bf8946f3c44336c73f0f494e03b 100644 (file)
@@ -67,9 +67,7 @@ loopy_wait()
        while true
        do
                local out
-               out=$("$@")
-               local ret=$?
-               if ((!ret)); then
+               if out=$("$@"); then
                        echo -n "$out"
                        return 0
                fi