]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/ethernet: Use never-managed version of pci_intx()
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 9 Dec 2024 13:06:25 +0000 (14:06 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Sat, 18 Jan 2025 20:38:49 +0000 (14:38 -0600)
pci_intx() is a hybrid function which can sometimes be managed through
devres. To remove this hybrid nature from pci_intx(), it is necessary to
port users to either an always-managed or a never-managed version.

broadcom/bnx2x and brocade/bna enable their PCI devices with
pci_enable_device(). Thus, they need the never-managed version.

Replace pci_intx() with pci_intx_unmanaged().

Link: https://lore.kernel.org/r/20241209130632.132074-5-pstanner@redhat.com
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
drivers/net/ethernet/brocade/bna/bnad.c

index 678829646cec393cc1bffd844866b5fdf591e472..2ae63d6e679258587f0e586c8133c116fa484e53 100644 (file)
@@ -1669,7 +1669,7 @@ static void bnx2x_igu_int_enable(struct bnx2x *bp)
        REG_WR(bp, IGU_REG_PF_CONFIGURATION, val);
 
        if (val & IGU_PF_CONF_INT_LINE_EN)
-               pci_intx(bp->pdev, true);
+               pci_intx_unmanaged(bp->pdev, true);
 
        barrier();
 
index ece6f3b483273832bc2fd0fe611e4bab15843ff6..2b37462d406ed78cf968b0a031406f5325335e42 100644 (file)
@@ -2669,7 +2669,7 @@ bnad_enable_msix(struct bnad *bnad)
                }
        }
 
-       pci_intx(bnad->pcidev, 0);
+       pci_intx_unmanaged(bnad->pcidev, 0);
 
        return;