]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
btrfs: return bool from check_tree_block_fsid instead of int
authorAnand Jain <anand.jain@oracle.com>
Wed, 24 May 2023 12:02:39 +0000 (20:02 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 19 Jun 2023 11:59:29 +0000 (13:59 +0200)
Simplify the return type of check_tree_block_fsid() from int (1 or 0) to
bool. Its only user is interested in knowing the success or failure.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c

index a3366fe546b1c9b59083c9fa21e94b7b83e0f60d..8102d2aa3f62da0b66505baeafdd17b722f297cc 100644 (file)
@@ -317,7 +317,7 @@ error:
        return errno_to_blk_status(ret);
 }
 
-static int check_tree_block_fsid(struct extent_buffer *eb)
+static bool check_tree_block_fsid(struct extent_buffer *eb)
 {
        struct btrfs_fs_info *fs_info = eb->fs_info;
        struct btrfs_fs_devices *fs_devices = fs_info->fs_devices, *seed_devs;
@@ -337,13 +337,13 @@ static int check_tree_block_fsid(struct extent_buffer *eb)
                metadata_uuid = fs_devices->fsid;
 
        if (!memcmp(fsid, metadata_uuid, BTRFS_FSID_SIZE))
-               return 0;
+               return false;
 
        list_for_each_entry(seed_devs, &fs_devices->seed_list, seed_list)
                if (!memcmp(fsid, seed_devs->fsid, BTRFS_FSID_SIZE))
-                       return 0;
+                       return false;
 
-       return 1;
+       return true;
 }
 
 /* Do basic extent buffer checks at read time */