]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
platform/x86:intel/pmc: Use the return value of pmc_core_send_msg
authorXi Pardee <xi.pardee@intel.com>
Mon, 24 Jun 2024 20:32:10 +0000 (13:32 -0700)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 8 Jul 2024 07:37:53 +0000 (10:37 +0300)
Use the return value of pmc_core_send_msg() directly instead of
assigning another code when an error occurs.

Signed-off-by: Xi Pardee <xi.pardee@intel.com>
Link: https://lore.kernel.org/r/20240624203218.2428475-2-xi.pardee@linux.intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/pmc/core.c

index 65eb09c7af6ae563088d7f50a779e65248f39dff..e656d51e7ad57a1ba5ea6f30c28ff48d786baa63 100644 (file)
@@ -403,18 +403,16 @@ static int pmc_core_mphy_pg_show(struct seq_file *s, void *unused)
 
        mutex_lock(&pmcdev->lock);
 
-       if (pmc_core_send_msg(pmc, &mphy_core_reg_low) != 0) {
-               err = -EBUSY;
+       err = pmc_core_send_msg(pmc, &mphy_core_reg_low);
+       if (err)
                goto out_unlock;
-       }
 
        msleep(10);
        val_low = pmc_core_reg_read(pmc, SPT_PMC_MFPMC_OFFSET);
 
-       if (pmc_core_send_msg(pmc, &mphy_core_reg_high) != 0) {
-               err = -EBUSY;
+       err = pmc_core_send_msg(pmc, &mphy_core_reg_high);
+       if (err)
                goto out_unlock;
-       }
 
        msleep(10);
        val_high = pmc_core_reg_read(pmc, SPT_PMC_MFPMC_OFFSET);
@@ -455,10 +453,9 @@ static int pmc_core_pll_show(struct seq_file *s, void *unused)
        mphy_common_reg  = (SPT_PMC_MPHY_COM_STS_0 << 16);
        mutex_lock(&pmcdev->lock);
 
-       if (pmc_core_send_msg(pmc, &mphy_common_reg) != 0) {
-               err = -EBUSY;
+       err = pmc_core_send_msg(pmc, &mphy_common_reg);
+       if (err)
                goto out_unlock;
-       }
 
        /* Observed PMC HW response latency for MTPMC-MFPMC is ~10 ms */
        msleep(10);