scsi: target: iscs: Make write_pending_must_be_called a bit field

Subsequent commits add more on/off type of settings to the
target_core_fabric_ops struct so this makes write_pending_must_be_called a
bit field instead of a bool to better organize the settings.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20230928020907.5730-1-michael.christie@oracle.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index 1cff6052e820219eaab4f4061117154d40596d3a..bf190dcb9eee2077dbafcd6260016271d3cc90bf 100644 (file)
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -1589,5 +1589,5 @@ const struct target_core_fabric_ops iscsi_ops = {
        .tfc_tpg_nacl_auth_attrs        = lio_target_nacl_auth_attrs,
        .tfc_tpg_nacl_param_attrs       = lio_target_nacl_param_attrs,
 
-       .write_pending_must_be_called   = true,
+       .write_pending_must_be_called   = 1,
 };

diff --git a/include/target/target_core_fabric.h b/include/target/target_core_fabric.h
index b188b1e90e1edb945f0d6cee5e3e3731a16de67e..2a6c4c935666aaf212df3a61757e274c4c4b4fef 100644 (file)
--- a/include/target/target_core_fabric.h
+++ b/include/target/target_core_fabric.h
@@ -113,11 +113,11 @@ struct target_core_fabric_ops {
        struct configfs_attribute **tfc_tpg_nacl_param_attrs;
 
        /*
-        * Set this member variable to true if the SCSI transport protocol
+        * Set this member variable if the SCSI transport protocol
         * (e.g. iSCSI) requires that the Data-Out buffer is transferred in
         * its entirety before a command is aborted.
         */
-       bool write_pending_must_be_called;
+       unsigned int write_pending_must_be_called:1;
 };
 
 int target_register_template(const struct target_core_fabric_ops *fo);