]> www.infradead.org Git - users/hch/configfs.git/commitdiff
netxen_nic: Use {low,upp}er_32_bits() helpers
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 8 Jul 2024 09:25:14 +0000 (11:25 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Jul 2024 02:01:01 +0000 (19:01 -0700)
Use the existing {low,upp}er_32_bits() helpers instead of defining
custom variants.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/319d4a5313ac75f7bbbb6b230b6802b18075c3e0.1720430602.git.geert+renesas@glider.be
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c

index 2fcbcecb41d17a34037b5fa30ebd4e0312d75d74..fef4b2b0b1f268ddea91747cc7d28a13de1fb0aa 100644 (file)
@@ -571,9 +571,6 @@ static u64 ctx_addr_sig_regs[][3] = {
 #define CRB_CTX_ADDR_REG_HI(FUNC_ID)   (ctx_addr_sig_regs[FUNC_ID][2])
 #define CRB_CTX_SIGNATURE_REG(FUNC_ID) (ctx_addr_sig_regs[FUNC_ID][1])
 
-#define lower32(x)     ((u32)((x) & 0xffffffff))
-#define upper32(x)     ((u32)(((u64)(x) >> 32) & 0xffffffff))
-
 static struct netxen_recv_crb recv_crb_registers[] = {
        /* Instance 0 */
        {
@@ -723,9 +720,9 @@ netxen_init_old_ctx(struct netxen_adapter *adapter)
                NETXEN_CTX_SIGNATURE_V2 : NETXEN_CTX_SIGNATURE;
 
        NXWR32(adapter, CRB_CTX_ADDR_REG_LO(port),
-                       lower32(recv_ctx->phys_addr));
+                       lower_32_bits(recv_ctx->phys_addr));
        NXWR32(adapter, CRB_CTX_ADDR_REG_HI(port),
-                       upper32(recv_ctx->phys_addr));
+                       upper_32_bits(recv_ctx->phys_addr));
        NXWR32(adapter, CRB_CTX_SIGNATURE_REG(port),
                        signature | port);
        return 0;