]> www.infradead.org Git - users/hch/misc.git/commitdiff
ALSA: cs4281: Send the PCM period elapsed notification properly
authorChandra Mohan Sundar <chandramohan.explore@gmail.com>
Sat, 6 Sep 2025 16:21:54 +0000 (21:51 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 6 Sep 2025 17:55:10 +0000 (19:55 +0200)
As part of spin lock code cleanup using guard(), a new
variable (period_elapsed) was introduced. However this variable
is never set, causing period elapsed notification to be not sent.

Set the value of period_elapsed appropiately.

This issue was reported by static coverity analyzer.

Fixes: 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks")
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Link: https://patch.msgid.link/20250906162158.564899-1-chandramohan.explore@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/cs4281.c

index c519fb9cdd1ee1cb44ee4b2a6751a23831a1b5c3..d00b2c9fb1e38c3af148d72fbad7af999c035273 100644 (file)
@@ -1752,6 +1752,7 @@ static irqreturn_t snd_cs4281_interrupt(int irq, void *dev_id)
                                        chip->spurious_dtc_irq++;
                                        continue;
                                }
+                               period_elapsed = true;
                        }
                        if (period_elapsed)
                                snd_pcm_period_elapsed(cdma->substream);