]> www.infradead.org Git - users/hch/misc.git/commitdiff
HID: playstation: Prefer kzalloc(sizeof(*buf)...)
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tue, 24 Jun 2025 21:56:52 +0000 (00:56 +0300)
committerJiri Kosina <jkosina@suse.com>
Wed, 17 Sep 2025 09:33:43 +0000 (11:33 +0200)
Use the shorter variant as suggested by checkpatch.pl:

  CHECK: Prefer kzalloc(sizeof(*buf)...) over kzalloc(sizeof(struct dualsense_output_report_bt)...)

This also improves further maintainability.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Benjamin Tissoires <bentiss@kernel.org>
Tested-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-playstation.c

index 37fc1a74517c1f14a7bae9a1fa90f7d64115a605..6e3132418f2ef88f49d7ea55eb1f52ddf53680c1 100644 (file)
@@ -1531,9 +1531,9 @@ static void dualsense_remove(struct ps_device *ps_dev)
 static int dualsense_reset_leds(struct dualsense *ds)
 {
        struct dualsense_output_report report;
-       u8 *buf;
+       struct dualsense_output_report_bt *buf;
 
-       buf = kzalloc(sizeof(struct dualsense_output_report_bt), GFP_KERNEL);
+       buf = kzalloc(sizeof(*buf), GFP_KERNEL);
        if (!buf)
                return -ENOMEM;