ubiupdatevol: Prevent null pointer dereference

libubi_close(libubi) is called in the error handler if libubi is null.
Prevent that by handling the error case similar to the other ubi
executables.

Signed-off-by: Bastian Germann <bastiangermann@fishpost.de>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

diff --git a/ubi-utils/ubiupdatevol.c b/ubi-utils/ubiupdatevol.c
index bdcc09180bd775283f5737e004cdbdb3882fa667..1b3239ef4affb38294922583b1252f9aa232ad53 100644 (file)
--- a/ubi-utils/ubiupdatevol.c
+++ b/ubi-utils/ubiupdatevol.c
@@ -308,9 +308,7 @@ int main(int argc, char * const argv[])
        if (!libubi) {
                if (errno == 0)
                        errmsg("UBI is not present in the system");
-               else
-                       sys_errmsg("cannot open libubi");
-               goto out_libubi;
+               return sys_errmsg("cannot open libubi");
        }
 
        err = ubi_probe_node(libubi, args.node);