]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
[mpt2sas] Fix several endian issues found by runing sparse
authorNagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
Mon, 7 May 2012 20:37:24 +0000 (13:37 -0700)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Wed, 9 May 2012 00:32:35 +0000 (17:32 -0700)
Orabug: 14040678
Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
Signed-off-by: Maxim Uvarov <maxim.uvarov@oracle.com>
drivers/scsi/mpt2sas/mpt2sas_base.c
drivers/scsi/mpt2sas/mpt2sas_scsih.c

index c3a143dbdc600305482d125780ec91de5958d935..c48ca9d6bac0cfbb51e58fbda14974cc8af5c3bf 100644 (file)
@@ -4172,7 +4172,8 @@ _base_make_ioc_operational(struct MPT2SAS_ADAPTER *ioc, int sleep_flag)
        if (ioc->is_driver_loading) {
                if (ioc->is_warpdrive && ioc->manu_pg10.OEMIdentifier
                    == 0x80) {
-                       hide_flag = (u8) (ioc->manu_pg10.OEMSpecificFlags0 &
+                       hide_flag = (u8) (
+                           le32_to_cpu(ioc->manu_pg10.OEMSpecificFlags0) &
                            MFG_PAGE10_HIDE_SSDS_MASK);
                        if (hide_flag != MFG_PAGE10_HIDE_SSDS_MASK)
                                ioc->mfg_pg10_hide_flag = hide_flag;
index e1dbd97d5864b3081dcb682566160a7f6ea5662f..6208ba6d2bc331d888502dd254196a6ed01f9bff 100644 (file)
@@ -1859,7 +1859,8 @@ _scsih_init_warpdrive_properties(struct MPT2SAS_ADAPTER *ioc,
                if (mpt2sas_config_get_phys_disk_pg0(ioc, &mpi_reply,
                    &pd_pg0, MPI2_PHYSDISK_PGAD_FORM_PHYSDISKNUM,
                    vol_pg0->PhysDisk[count].PhysDiskNum) ||
-                   pd_pg0.DevHandle == MPT2SAS_INVALID_DEVICE_HANDLE) {
+                    le16_to_cpu(pd_pg0.DevHandle) ==
+                   MPT2SAS_INVALID_DEVICE_HANDLE) {
                        printk(MPT2SAS_INFO_FMT "WarpDrive : Direct IO is "
                            "disabled for the drive with handle(0x%04x) member"
                            "handle retrieval failed for member number=%d\n",
@@ -7406,14 +7407,14 @@ mpt2sas_scsih_event_callback(struct MPT2SAS_ADAPTER *ioc, u8 msix_index,
        case MPI2_EVENT_LOG_ENTRY_ADDED:
        {
                Mpi2EventDataLogEntryAdded_t *log_entry;
-               u32 *log_code;
+               __le32 *log_code;
 
                if (!ioc->is_warpdrive)
                        break;
 
                log_entry = (Mpi2EventDataLogEntryAdded_t *)
                    mpi_reply->EventData;
-               log_code = (u32 *)log_entry->LogData;
+               log_code = (__le32 *)log_entry->LogData;
 
                if (le16_to_cpu(log_entry->LogEntryQualifier)
                    != MPT2_WARPDRIVE_LOGENTRY)