]> www.infradead.org Git - users/willy/xarray.git/commitdiff
virtio_net: Fix error handling in virtnet_restore()
authorXie Yongji <xieyongji@bytedance.com>
Mon, 17 May 2021 08:45:16 +0000 (16:45 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Sat, 3 Jul 2021 08:50:52 +0000 (04:50 -0400)
Do some cleanups in virtnet_restore() when virtnet_cpu_notif_add() failed.

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20210517084516.332-1-xieyongji@bytedance.com
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/virtio_net.c

index b0b81458ca94eb5b0a312dbb3f55cf7e10bc1f56..4fff7cd24a889426fc01287f931f7645cdba4b14 100644 (file)
@@ -3310,8 +3310,11 @@ static __maybe_unused int virtnet_restore(struct virtio_device *vdev)
        virtnet_set_queues(vi, vi->curr_queue_pairs);
 
        err = virtnet_cpu_notif_add(vi);
-       if (err)
+       if (err) {
+               virtnet_freeze_down(vdev);
+               remove_vq_common(vi);
                return err;
+       }
 
        return 0;
 }