]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: stmmac: meson8b: remove of_get_phy_mode()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 12 Mar 2025 09:20:47 +0000 (09:20 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 14:53:15 +0000 (15:53 +0100)
devm_stmmac_probe_config_dt() already gets the PHY mode from firmware,
which is stored in plat_dat->phy_interface. Therefore, we don't need to
get it in platform code.

Set dwmac->phy_mode from plat_dat->phy_interface.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tsIGd-005uzr-0C@rmk-PC.armlinux.org.uk
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c

index 9c2d62d133ade6e24de378111cc296e9b150f654..a50782994b979895cc37aae21ac973230394250d 100644 (file)
@@ -417,11 +417,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev)
                return PTR_ERR(dwmac->regs);
 
        dwmac->dev = &pdev->dev;
-       ret = of_get_phy_mode(pdev->dev.of_node, &dwmac->phy_mode);
-       if (ret) {
-               dev_err(&pdev->dev, "missing phy-mode property\n");
-               return ret;
-       }
+       dwmac->phy_mode = plat_dat->phy_interface;
 
        /* use 2ns as fallback since this value was previously hardcoded */
        if (of_property_read_u32(pdev->dev.of_node, "amlogic,tx-delay-ns",