]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ice: block SF port creation in legacy mode
authorMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Mon, 21 Oct 2024 23:26:25 +0000 (16:26 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 29 Oct 2024 14:24:53 +0000 (15:24 +0100)
There is no support for SF in legacy mode. Reflect it in the code.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Fixes: eda69d654c7e ("ice: add basic devlink subfunctions support")
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/intel/ice/devlink/devlink_port.c

index 928c8bdb66494a15928ef63ed8e4176f38020fc7..c6779d9dffffda95ec1811b520f3e05101caa44a 100644 (file)
@@ -989,5 +989,11 @@ ice_devlink_port_new(struct devlink *devlink,
        if (err)
                return err;
 
+       if (!ice_is_eswitch_mode_switchdev(pf)) {
+               NL_SET_ERR_MSG_MOD(extack,
+                                  "SF ports are only supported in eswitch switchdev mode");
+               return -EOPNOTSUPP;
+       }
+
        return ice_alloc_dynamic_port(pf, new_attr, extack, devlink_port);
 }