dell-wmi: Ignore WMI event code 0xe045

>From Dell we know that WMI event code 0xe045 is for Num Lock key, but it is
unclear due to message in commit 0b3f6109f0c9 ("dell-wmi: new driver for
hotkey control").

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Michał Kępień <kernel@kempniu.pl>
Tested-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Reviewed-by: Michał Kępień <kernel@kempniu.pl>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Mario Limonciello <mario_limonciello@dell.com>
Link: https://lkml.org/lkml/2015/7/7/830
Signed-off-by: Darren Hart <dvhart@linux.intel.com>

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 15c6f1191aec3f1aa7751b3b935d2d871bc599dd..4d23c910afebb8a009b462fd330583bcfb54485c 100644 (file)
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -88,7 +88,6 @@ static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = {
 static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
        { KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },
 
-       { KE_KEY, 0xe045, { KEY_PROG1 } },
        { KE_KEY, 0xe009, { KEY_EJECTCD } },
 
        /* These also contain the brightness level at offset 6 */
@@ -130,7 +129,19 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
        { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
        { KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } },
        { KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } },
+
+       /*
+        * This entry is very suspicious!
+        * Originally Matthew Garrett created this dell-wmi driver specially for
+        * "button with a picture of a battery" which has event code 0xe045.
+        * Later Mario Limonciello from Dell told us that event code 0xe045 is
+        * reported by Num Lock and should be ignored because key is send also
+        * by keyboard controller.
+        * So for now we will ignore this event to prevent potential double
+        * Num Lock key press.
+        */
        { KE_IGNORE, 0xe045, { KEY_NUMLOCK } },
+
        { KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } },
        { KE_IGNORE, 0xe0f7, { KEY_MUTE } },
        { KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } },