]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
rtla: Fix the help text in osnoise and timerlat top tools
authorEder Zulian <ezulian@redhat.com>
Tue, 13 Aug 2024 15:58:31 +0000 (17:58 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 3 Oct 2024 20:43:22 +0000 (16:43 -0400)
The help text in osnoise top and timerlat top had some minor errors
and omissions. The -d option was missing the 's' (second) abbreviation and
the error message for '-d' used '-D'.

Cc: stable@vger.kernel.org
Fixes: 1eceb2fc2ca54 ("rtla/osnoise: Add osnoise top mode")
Fixes: a828cd18bc4ad ("rtla: Add timerlat tool and timelart top mode")
Link: https://lore.kernel.org/20240813155831.384446-1-ezulian@redhat.com
Suggested-by: Tomas Glozar <tglozar@redhat.com>
Reviewed-by: Tomas Glozar <tglozar@redhat.com>
Signed-off-by: Eder Zulian <ezulian@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
tools/tracing/rtla/src/osnoise_top.c
tools/tracing/rtla/src/timerlat_top.c

index 2f756628613dd82d86a22e1e17752c7e3f36c941..30e3853076a0daa7e3c7c0a7f420f37f03605e89 100644 (file)
@@ -442,7 +442,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
                case 'd':
                        params->duration = parse_seconds_duration(optarg);
                        if (!params->duration)
-                               osnoise_top_usage(params, "Invalid -D duration\n");
+                               osnoise_top_usage(params, "Invalid -d duration\n");
                        break;
                case 'e':
                        tevent = trace_event_alloc(optarg);
index 8c16419fe22aa7b7791fb144932ca4f79be97583..210b0f533534abf2834945d2960dcc0a04ae817c 100644 (file)
@@ -459,7 +459,7 @@ static void timerlat_top_usage(char *usage)
                "         -c/--cpus cpus: run the tracer only on the given cpus",
                "         -H/--house-keeping cpus: run rtla control threads only on the given cpus",
                "         -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",
-               "         -d/--duration time[m|h|d]: duration of the session in seconds",
+               "         -d/--duration time[s|m|h|d]: duration of the session",
                "         -D/--debug: print debug info",
                "            --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",
                "         -t/--trace[file]: save the stopped trace to [file|timerlat_trace.txt]",
@@ -613,7 +613,7 @@ static struct timerlat_top_params
                case 'd':
                        params->duration = parse_seconds_duration(optarg);
                        if (!params->duration)
-                               timerlat_top_usage("Invalid -D duration\n");
+                               timerlat_top_usage("Invalid -d duration\n");
                        break;
                case 'e':
                        tevent = trace_event_alloc(optarg);