]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ibmvnic: Process crqs after enabling interrupts
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Fri, 29 Oct 2021 22:03:15 +0000 (15:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:11 +0000 (11:36 +0100)
[ Upstream commit 6e20d00158f31f7631d68b86996b7e951c4451c8 ]

Soon after registering a CRQ it is possible that we get a fail over or
maybe a CRQ_INIT from the VIOS while interrupts were disabled.

Look for any such CRQs after enabling interrupts.

Otherwise we can intermittently fail to bring up ibmvnic adapters during
boot, specially in kexec/kdump kernels.

Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol")
Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c

index d97641b9928bb8d5e75e2b9c2d3af3f58dd80c00..c52c26fc44e59b46567c06437513f512e9b97c53 100644 (file)
@@ -4603,6 +4603,9 @@ static int init_crq_queue(struct ibmvnic_adapter *adapter)
        crq->cur = 0;
        spin_lock_init(&crq->lock);
 
+       /* process any CRQs that were queued before we enabled interrupts */
+       tasklet_schedule(&adapter->tasklet);
+
        return retrc;
 
 req_irq_failed: