crypto: qat - fix invalid check for RSA keylen in fips mode

The condition checking allowed key length was invalid.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 13a76a0325eda85eeb82545e644ed1db85bcc148..557a7408710da1b021e2b36b282d8b8e8e1fb5eb 100644 (file)
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -443,7 +443,7 @@ int qat_rsa_get_n(void *context, size_t hdrlen, unsigned char tag,
        ctx->key_sz = vlen;
        ret = -EINVAL;
        /* In FIPS mode only allow key size 2K & 3K */
-       if (fips_enabled && (ctx->key_sz != 256 || ctx->key_sz != 384)) {
+       if (fips_enabled && (ctx->key_sz != 256 && ctx->key_sz != 384)) {
                pr_err("QAT: RSA: key size not allowed in FIPS mode\n");
                goto err;
        }
@@ -510,7 +510,7 @@ int qat_rsa_get_d(void *context, size_t hdrlen, unsigned char tag,
                goto err;
 
        /* In FIPS mode only allow key size 2K & 3K */
-       if (fips_enabled && (vlen != 256 || vlen != 384)) {
+       if (fips_enabled && (vlen != 256 && vlen != 384)) {
                pr_err("QAT: RSA: key size not allowed in FIPS mode\n");
                goto err;
        }