]> www.infradead.org Git - users/hch/configfs.git/commitdiff
net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 28 Sep 2024 10:04:01 +0000 (13:04 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 00:25:32 +0000 (17:25 -0700)
This error handling has a typo.  It should i++ instead of i--.  In the
original code the error handling will loop until it crashes.

Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://patch.msgid.link/8e7960cc-415d-48d7-99ce-f623022ec7b5@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index cbe99017cbfa479fe8329c2c65394e45539cb709..d253727b160f5fb83be8ef83d1dbf6795b95a20a 100644 (file)
@@ -763,7 +763,7 @@ fail_tx:
        k3_udma_glue_disable_rx_chn(rx_chn->rx_chn);
 
 fail_rx:
-       for (i = 0; i < common->rx_ch_num_flows; i--)
+       for (i = 0; i < common->rx_ch_num_flows; i++)
                k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i],
                                          am65_cpsw_nuss_rx_cleanup, 0);