nvme: fix unreacheable code in verify_cmd()

the "if (err < 0)" condition should be checked before "if (err)",
otherwise it would be never caught.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

diff --git a/nvme.c b/nvme.c
index d1e517c4fd3fee92f3fc15a56a5647118c27f94d..74970649baf83e85f454f3d98bdf606852d062e7 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -5723,12 +5723,12 @@ static int write_zeroes(int argc, char **argv, struct command *cmd, struct plugi
        }
 
        err = nvme_cli_identify_ns(dev, cfg.namespace_id, &ns);
-       if (err) {
-               nvme_show_status(err);
-               goto close_dev;
-       } else if (err < 0) {
+       if (err < 0) {
                fprintf(stderr, "identify namespace: %s\n", nvme_strerror(errno));
                goto close_dev;
+       } else if (err) {
+               nvme_show_status(err);
+               goto close_dev;
        }
 
        err = nvme_identify_ns_csi(dev_fd(dev), cfg.namespace_id, 0,
@@ -6955,12 +6955,12 @@ static int verify_cmd(int argc, char **argv, struct command *cmd, struct plugin
        }
 
        err = nvme_cli_identify_ns(dev, cfg.namespace_id, &ns);
-       if (err) {
-               nvme_show_status(err);
-               goto close_dev;
-       } else if (err < 0) {
+       if (err < 0) {
                fprintf(stderr, "identify namespace: %s\n", nvme_strerror(errno));
                goto close_dev;
+       } else if (err) {
+               nvme_show_status(err);
+               goto close_dev;
        }
 
        err = nvme_identify_ns_csi(dev_fd(dev), cfg.namespace_id, 0,