]> www.infradead.org Git - users/hch/misc.git/commitdiff
bnxt_en: Drop redundant if block in bnxt_dl_flash_update()
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Wed, 17 Sep 2025 04:08:30 +0000 (21:08 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 18 Sep 2025 11:09:42 +0000 (13:09 +0200)
The devlink stack has sanity checks and it invokes flash_update()
only if it is supported by the driver.  The VF driver does not
advertise the support for flash_update in struct devlink_ops.
This makes if condition inside bnxt_dl_flash_update() redundant.

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250917040839.1924698-2-michael.chan@broadcom.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

index 43fb75806cd64b066efa616c19f80817947c1c66..d0f5507e85aa65290f08e7b713de7e636636dac1 100644 (file)
@@ -40,12 +40,6 @@ bnxt_dl_flash_update(struct devlink *dl,
        struct bnxt *bp = bnxt_get_bp_from_dl(dl);
        int rc;
 
-       if (!BNXT_PF(bp)) {
-               NL_SET_ERR_MSG_MOD(extack,
-                                  "flash update not supported from a VF");
-               return -EPERM;
-       }
-
        devlink_flash_update_status_notify(dl, "Preparing to flash", NULL, 0, 0);
        rc = bnxt_flash_package_from_fw_obj(bp->dev, params->fw, 0, extack);
        if (!rc)