]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/panthor: avoid garbage value in panthor_ioctl_dev_query()
authorSu Hui <suhui@nfschina.com>
Sun, 19 Jan 2025 02:58:29 +0000 (10:58 +0800)
committerBoris Brezillon <boris.brezillon@collabora.com>
Fri, 7 Feb 2025 16:31:59 +0000 (17:31 +0100)
'priorities_info' is uninitialized, and the uninitialized value is copied
to user object when calling PANTHOR_UOBJ_SET(). Using memset to initialize
'priorities_info' to avoid this garbage value problem.

Fixes: f70000ef2352 ("drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250119025828.1168419-1-suhui@nfschina.com
drivers/gpu/drm/panthor/panthor_drv.c

index d5dcd3d1b33a0ec29a1b304f4ee37839bfb1704f..08136e790ca0a65bf82e1acd5378cfbd534e5820 100644 (file)
@@ -802,6 +802,7 @@ static void panthor_query_group_priorities_info(struct drm_file *file,
 {
        int prio;
 
+       memset(arg, 0, sizeof(*arg));
        for (prio = PANTHOR_GROUP_PRIORITY_REALTIME; prio >= 0; prio--) {
                if (!group_priority_permit(file, prio))
                        arg->allowed_mask |= BIT(prio);