]> www.infradead.org Git - nvme.git/commitdiff
net: ethernet: mediatek: Allow gaps in MAC allocation
authorDaniel Golle <daniel@makrotopia.org>
Mon, 1 Jul 2024 19:28:14 +0000 (20:28 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 5 Jul 2024 23:58:38 +0000 (16:58 -0700)
Some devices with MediaTek SoCs don't use the first but only the second
MAC in the chip. Especially with MT7981 which got a built-in 1GE PHY
connected to the second MAC this is quite common.
Make sure to reset and enable PSE also in those cases by skipping gaps
using 'continue' instead of aborting the loop using 'break'.

Fixes: dee4dd10c79a ("net: ethernet: mtk_eth_soc: ppe: add support for multiple PPEs")
Suggested-by: Elad Yifee <eladwf@gmail.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/379ae584cea112db60f4ada79c7e5ba4f3364a64.1719862038.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 13d78d9b31972823de711ce4ea1490ed21606db2..2529b5b607c895d95dc83b65c96aef9e809964e6 100644 (file)
@@ -3396,7 +3396,7 @@ static int mtk_open(struct net_device *dev)
 
                for (i = 0; i < MTK_MAX_DEVS; i++) {
                        if (!eth->netdev[i])
-                               break;
+                               continue;
 
                        target_mac = netdev_priv(eth->netdev[i]);
                        if (!soc->offload_version) {